adamdebreceni commented on code in PR #1930:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1930#discussion_r2213169556
##########
libminifi/src/core/FlowConfiguration.cpp:
##########
@@ -71,28 +71,17 @@ FlowConfiguration::~FlowConfiguration() {
}
}
-std::unique_ptr<core::Processor> FlowConfiguration::createProcessor(const
std::string &name, const utils::Identifier &uuid) {
- auto processor = minifi::processors::ProcessorUtils::createProcessor(name,
name, uuid);
+std::unique_ptr<core::Processor> FlowConfiguration::createProcessor(const
std::string &class_short, const std::string &fullclass, const std::string
&name, const utils::Identifier &uuid) {
+ auto processor =
minifi::processors::ProcessorUtils::createProcessor(class_short, fullclass,
name, uuid);
if (nullptr == processor) {
- logger_->log_error("No Processor defined for {}", name);
- return nullptr;
- }
- return processor;
-}
-
-std::unique_ptr<core::Processor> FlowConfiguration::createProcessor(const
std::string &name, const std::string &fullname, const utils::Identifier &uuid) {
- auto processor = minifi::processors::ProcessorUtils::createProcessor(name,
fullname, uuid);
- if (nullptr == processor) {
- logger_->log_error("No Processor defined for {}", fullname);
+ logger_->log_error("No Processor defined for {}", fullclass);
return nullptr;
}
return processor;
}
std::unique_ptr<core::reporting::SiteToSiteProvenanceReportingTask>
FlowConfiguration::createProvenanceReportTask() {
- auto processor =
std::make_unique<org::apache::nifi::minifi::core::reporting::SiteToSiteProvenanceReportingTask>(this->configuration_);
- processor->initialize();
- return processor;
+ return
std::make_unique<org::apache::nifi::minifi::core::reporting::SiteToSiteProvenanceReportingTask>(this->configuration_);
Review Comment:
it was safe, there is a call to it on
[StructuredConfiguration.cpp:637](https://github.com/adamdebreceni/nifi-minifi-cpp/blob/b3fc3279b8f527f7456bc193434688f39b0cea76/libminifi/src/core/flow/StructuredConfiguration.cpp#L637)
but I thought about it, and instead restored this one, and removed the
linked one, and also did some wrapping into the `Processor` wrapper instead of
the responsibility being scattered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
