adamdebreceni commented on code in PR #1930:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1930#discussion_r2213377392
##########
libminifi/include/core/reporting/SiteToSiteProvenanceReportingTask.h:
##########
@@ -35,8 +35,8 @@ namespace org::apache::nifi::minifi::core::reporting {
class SiteToSiteProvenanceReportingTask : public
minifi::RemoteProcessorGroupPort {
public:
explicit SiteToSiteProvenanceReportingTask(std::shared_ptr<Configure>
configure)
- : minifi::RemoteProcessorGroupPort(ReportTaskName, "",
std::move(configure)),
-
logger_(logging::LoggerFactory<SiteToSiteProvenanceReportingTask>::getLogger())
{
+ : minifi::RemoteProcessorGroupPort(ReportTaskName, "",
std::move(configure),
+
utils::IdGenerator::getIdGenerator()->generate(),
logging::LoggerFactory<SiteToSiteProvenanceReportingTask>::getLogger()) {
Review Comment:
done
##########
libminifi/src/core/flow/StructuredConnectionParser.cpp:
##########
@@ -41,8 +41,7 @@ void
StructuredConnectionParser::addFunnelRelationshipToConnection(minifi::Conne
return;
}
- auto& processor_ref = *processor;
- if (typeid(minifi::Funnel) == typeid(processor_ref)) {
+ if (dynamic_cast<minifi::Funnel*>(&processor->getImpl())) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
