xichen01 commented on code in PR #7109:
URL: https://github.com/apache/ozone/pull/7109#discussion_r2008750162
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -294,6 +294,14 @@ enum ReplicationFactor {
ZERO = 0; // Invalid Factor
}
+enum StorageType {
Review Comment:
Both `hdds.proto` and `ScmServerDatanodeHeartbeatProtocol.proto` are
`package hadoop.hdds;` so we cannot name it to `StorageTypeProto`
##########
hadoop-hdds/interface-server/src/main/proto/ScmServerDatanodeHeartbeatProtocol.proto:
##########
@@ -177,19 +177,21 @@ message StorageReportProto {
optional uint64 capacity = 3 [default = 0];
optional uint64 scmUsed = 4 [default = 0];
optional uint64 remaining = 5 [default = 0];
- optional StorageTypeProto storageType = 6 [default = DISK];
+ optional StorageTypeProto storageType = 6 [default = DISK, deprecated =
true];
Review Comment:
Thanks for your suggestion, I think this is compatibility, but the maven
plugin `proto-backwards-compatibility` will report error say the "field
CONFLICT".
And the plugin ` proto-backwards-compatibility` not support to ignore a
specific field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
