szetszwo commented on code in PR #7109:
URL: https://github.com/apache/ozone/pull/7109#discussion_r2008828783
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -294,6 +294,14 @@ enum ReplicationFactor {
ZERO = 0; // Invalid Factor
}
+enum StorageType {
Review Comment:
Since they are in the same package, we could safely move the
`StorageTypeProto` from ScmServerDatanodeHeartbeatProtocol.proto to hdds.proto.
The only difference is the `java_outer_classname`. Fortunately,
ScmServerDatanodeHeartbeatProtocol.proto is a non-user facing internal protocol
and the change is wire compatible. So there is no compatibility issues. See
https://issues.apache.org/jira/secure/attachment/13075616/7109_review.patch
BTW, let's rename ScmServerDatanodeHeartbeatProtocol.proto to
`StorageContainerDatanodeProtocol.proto`, i.e. make it consistent with the
`java_outer_classname`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
