szetszwo commented on code in PR #7109:
URL: https://github.com/apache/ozone/pull/7109#discussion_r2008828837
##########
hadoop-hdds/interface-server/src/main/proto/ScmServerDatanodeHeartbeatProtocol.proto:
##########
@@ -177,19 +177,21 @@ message StorageReportProto {
optional uint64 capacity = 3 [default = 0];
optional uint64 scmUsed = 4 [default = 0];
optional uint64 remaining = 5 [default = 0];
- optional StorageTypeProto storageType = 6 [default = DISK];
+ optional StorageTypeProto storageType = 6 [default = DISK, deprecated =
true];
Review Comment:
Please try
https://issues.apache.org/jira/secure/attachment/13075616/7109_review.patch
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -294,6 +294,14 @@ enum ReplicationFactor {
ZERO = 0; // Invalid Factor
}
+enum StorageType {
Review Comment:
Since they are in the same package, we could safely move the
`StorageTypeProto` from ScmServerDatanodeHeartbeatProtocol.proto to hdds.proto.
The only difference is the java_outer_classname. Fortunately,
ScmServerDatanodeHeartbeatProtocol.proto is a non-user facing internal protocol
and the change is wire compatible. The change is compatible. See
https://issues.apache.org/jira/secure/attachment/13075616/7109_review.patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
