xichen01 commented on code in PR #7109:
URL: https://github.com/apache/ozone/pull/7109#discussion_r2009033662
##########
hadoop-hdds/interface-server/src/main/proto/ScmServerDatanodeHeartbeatProtocol.proto:
##########
@@ -177,19 +177,21 @@ message StorageReportProto {
optional uint64 capacity = 3 [default = 0];
optional uint64 scmUsed = 4 [default = 0];
optional uint64 remaining = 5 [default = 0];
- optional StorageTypeProto storageType = 6 [default = DISK];
+ optional StorageTypeProto storageType = 6 [default = DISK, deprecated =
true];
Review Comment:
This will also cause proto-backwards-compatibility to report an error. It
seems that it is difficult for us to change the existing proto message
```bash
[INFO] --- proto-backwards-compatibility:1.0.7:backwards-compatibility-check
(default) @ hdds-interface-server ---
[INFO] protolock cmd line:
/Users/xichen/community/ozone/hadoop-hdds/interface-server/target/protolock-bin/protolock
status
--lockdir=/Users/xichen/community/ozone/hadoop-hdds/interface-server/target/classes
--protoroot=/Users/xichen/community/ozone/hadoop-hdds/interface-server/target/classes
[INFO] CONFLICT: "StorageTypeProto" field: "ARCHIVE" has been removed, but
is not reserved [ScmServerDatanodeHeartbeatProtocol.proto]
[INFO] CONFLICT: "StorageTypeProto" field: "DISK" has been removed, but is
not reserved [ScmServerDatanodeHeartbeatProtocol.proto]
[INFO] CONFLICT: "StorageTypeProto" field: "PROVIDED" has been removed, but
is not reserved [ScmServerDatanodeHeartbeatProtocol.proto]
[INFO] CONFLICT: "StorageTypeProto" field: "RAM_DISK" has been removed, but
is not reserved [ScmServerDatanodeHeartbeatProtocol.proto]
[INFO] CONFLICT: "StorageTypeProto" field: "SSD" has been removed, but is
not reserved [ScmServerDatanodeHeartbeatProtocol.proto]
[INFO] CONFLICT: "StorageTypeProto" integer: "1" has been removed, but is
not reserved [ScmServerDatanodeHeartbeatProtocol.proto]
[INFO] CONFLICT: "StorageTypeProto" integer: "2" has been removed, but is
not reserved [ScmServerDatanodeHeartbeatProtocol.proto]
[INFO] CONFLICT: "StorageTypeProto" integer: "3" has been removed, but is
not reserved [ScmServerDatanodeHeartbeatProtocol.proto]
[INFO] CONFLICT: "StorageTypeProto" integer: "4" has been removed, but is
not reserved [ScmServerDatanodeHeartbeatProtocol.proto]
[INFO] CONFLICT: "StorageTypeProto" integer: "5" has been removed, but is
not reserved [ScmServerDatanodeHeartbeatProtocol.proto]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
