jojochuang commented on code in PR #8315:
URL: https://github.com/apache/ozone/pull/8315#discussion_r2055076240
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/RootEndpoint.java:
##########
@@ -61,6 +62,9 @@ public Response get()
throw e;
}
+ OzoneVolume volume = getVolume();
+ response.setOwner(new S3Owner(volume.getName(), volume.getName()));
Review Comment:
```suggestion
response.setOwner(new S3Owner(0, volume.getOwner()));
```
The first argument of S3Owner is ID, which is a 64-character encoded unique
user name. We dont' support it in Ozone.
https://docs.aws.amazon.com/accounts/latest/reference/manage-acct-identifiers.html
@ivandika3 any ideas about the owner id?
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ListBucketResponse.java:
##########
@@ -39,6 +39,9 @@ public class ListBucketResponse {
@XmlElement(name = "Bucket")
private List<BucketMetadata> buckets = new ArrayList<>();
+ @XmlElement(name = "Owner")
+ private S3Owner owner;
Review Comment:
Unrelated, but S3Owner javadoc is not useful. We should fix it in another
task.
/**
* TODO: javadoc.
*/
@XmlAccessorType(XmlAccessType.FIELD)
@XmlRootElement(name = "Owner")
public class S3Owner {
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/RootEndpoint.java:
##########
@@ -61,6 +62,9 @@ public Response get()
throw e;
}
+ OzoneVolume volume = getVolume();
+ response.setOwner(new S3Owner(volume.getName(), volume.getName()));
Review Comment:
this line doesn't look right. The owner is the user owner of the volume, not
the name of the volume
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
