hevinhsu commented on code in PR #8315:
URL: https://github.com/apache/ozone/pull/8315#discussion_r2072752436
##########
hadoop-ozone/integration-test-s3/src/test/java/org/apache/hadoop/ozone/s3/S3ClientFactory.java:
##########
@@ -158,4 +160,54 @@ public S3Client createS3ClientV2(boolean enablePathStyle)
throws Exception {
.forcePathStyle(enablePathStyle)
.build();
}
+
+ /**
+ * Creates an S3AsyncClient (AWS SDK V2) with path style access enabled.
+ *
+ * @return S3AsyncClient
+ * @throws URISyntaxException if there is an error creating the client
+ */
+ public S3AsyncClient createS3AsyncClientV2() throws Exception {
Review Comment:
Hi,
I’ve implemented the S3AsyncClient based on the TODO in this file:
[link](https://github.com/apache/ozone/blob/master/hadoop-ozone/integration-test-s3/src/test/java/org/apache/hadoop/ozone/s3/awssdk/v2/AbstractS3SDKV2Tests.java#L93-L97)
I haven’t worked on the crt-based-s3-client test yet, since it would require
introducing a new dependency.
Just wanted to confirm—are both of these tests expected to be included as
part of this issue?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
