ivandika3 commented on code in PR #8315:
URL: https://github.com/apache/ozone/pull/8315#discussion_r2079152466
##########
hadoop-ozone/integration-test-s3/src/test/java/org/apache/hadoop/ozone/s3/awssdk/v2/AbstractS3SDKV2Tests.java:
##########
@@ -152,116 +133,6 @@ public void testPutObject() {
assertEquals("\"37b51d194a7513e45b56f6524f2d51f2\"",
getObjectResponse.eTag());
}
- @Test
- public void testListObjectsMany() throws Exception {
- testListObjectsMany(false);
- }
-
- @Test
- public void testListObjectsManyV2() throws Exception {
- testListObjectsMany(true);
- }
Review Comment:
Seems there is a mistake when merging to master and all of the
`AbstractS3SDKV2Tests` changes in https://github.com/apache/ozone/pull/8356
were removed. Please kindly revert all the deletions in this file.
##########
hadoop-ozone/integration-test-s3/src/test/java/org/apache/hadoop/ozone/s3/awssdk/v1/AbstractS3SDKV1Tests.java:
##########
@@ -249,7 +250,7 @@ public void testBucketACLOperations() {
}
@Test
- public void testListBuckets() {
+ public void testListBuckets() throws IOException {
Review Comment:
We can add this `testListBuckets` to `AbstractS3SDKV2Tests`.
##########
hadoop-ozone/integration-test-s3/src/test/java/org/apache/hadoop/ozone/s3/S3ClientFactory.java:
##########
@@ -158,4 +160,54 @@ public S3Client createS3ClientV2(boolean enablePathStyle)
throws Exception {
.forcePathStyle(enablePathStyle)
.build();
}
+
+ /**
+ * Creates an S3AsyncClient (AWS SDK V2) with path style access enabled.
+ *
+ * @return S3AsyncClient
+ * @throws URISyntaxException if there is an error creating the client
+ */
+ public S3AsyncClient createS3AsyncClientV2() throws Exception {
Review Comment:
@hevinhsu Thanks for considering `S3AsyncClient`. I think we can introduce
`S3AsyncClient` in another task which will add the S3 Async client in all
existing tests in `AbstractS3SDKV2Tests`. We can exclude `S3AsyncClient` and
focus on the synchronous `S3Client` for this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
