hevinhsu commented on code in PR #8315:
URL: https://github.com/apache/ozone/pull/8315#discussion_r2079146038
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/RootEndpoint.java:
##########
@@ -61,6 +62,9 @@ public Response get()
throw e;
}
+ OzoneVolume volume = getVolume();
Review Comment:
@jojochuang Thanks for the feedback!
I'm currently using a functional interface to inject the owner into the
response. This allows me to reuse the ```getVolume()``` error handling logic
inside BaseEndpoint and avoid passing the response object into it.
The goal is to keep error handling consistent and isolate response
construction from the base layer.
Could you help confirm if this approach aligns with our design expectations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
