tkhurana commented on code in PR #1969:
URL: https://github.com/apache/phoenix/pull/1969#discussion_r1767294625
##########
phoenix-core-client/src/main/java/org/apache/phoenix/index/IndexMaintainer.java:
##########
@@ -470,6 +471,7 @@ private IndexMaintainer(final PTable dataTable, final
PTable cdcTable, final PTa
this.immutableStorageScheme = index.getImmutableStorageScheme() ==
null ? ImmutableStorageScheme.ONE_CELL_PER_COLUMN :
index.getImmutableStorageScheme();
this.dataEncodingScheme = dataTable.getEncodingScheme() == null ?
QualifierEncodingScheme.NON_ENCODED_QUALIFIERS : dataTable.getEncodingScheme();
this.dataImmutableStorageScheme =
dataTable.getImmutableStorageScheme() == null ?
ImmutableStorageScheme.ONE_CELL_PER_COLUMN :
dataTable.getImmutableStorageScheme();
+ this.nDataTableSaltBuckets = isDataTableSalted ?
dataTable.getBucketNum() : PTable.NO_SALTING;
Review Comment:
Any reason why are you introducing the special value of -1 ? The field
`nIndexSaltBuckets` is set to 0 if index is not salted. We should maintain
consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
