haridsv commented on code in PR #1969:
URL: https://github.com/apache/phoenix/pull/1969#discussion_r1770769960
##########
phoenix-core-client/src/main/java/org/apache/phoenix/index/IndexMaintainer.java:
##########
@@ -1789,6 +1788,9 @@ public static IndexMaintainer
fromProto(ServerCachingProtos.IndexMaintainer prot
} else {
maintainer.isCDCIndex = false;
}
+ if (proto.hasDataTableSaltBuckets()) {
+ maintainer.nDataTableSaltBuckets = proto.getDataTableSaltBuckets();
Review Comment:
Agree on the inconsistency, but I think it should be set to `-1` to be
consistent than `0` for the same reason I
[mentioned](https://github.com/apache/phoenix/pull/1969/files#r1770766770) in
the other thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]