tkhurana commented on code in PR #1969:
URL: https://github.com/apache/phoenix/pull/1969#discussion_r1767324883
##########
phoenix-core-client/src/main/java/org/apache/phoenix/index/IndexMaintainer.java:
##########
@@ -1789,6 +1788,9 @@ public static IndexMaintainer
fromProto(ServerCachingProtos.IndexMaintainer prot
} else {
maintainer.isCDCIndex = false;
}
+ if (proto.hasDataTableSaltBuckets()) {
+ maintainer.nDataTableSaltBuckets = proto.getDataTableSaltBuckets();
Review Comment:
If the proto doesn't have data table salt buckets then what is the
nDataTableSaltBuckets field ? I think it will be 0 not -1. Seems like -1 is
constant that is introduced is unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
