kadirozde commented on code in PR #1964:
URL: https://github.com/apache/phoenix/pull/1964#discussion_r1771808083
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/CDCQueryIT.java:
##########
@@ -701,8 +698,14 @@ public void testCDCIndexBuildAndVerification() throws
Exception {
}
long startTS = System.currentTimeMillis();
- generateChanges(startTS, tenantids, tableFullName, tableFullName,
COMMIT_SUCCESS, null);
- EnvironmentEdgeManager.reset();
+ List<ChangeRow> changes = generateChanges(startTS, tenantids,
tableFullName,
+ tableFullName, COMMIT_SUCCESS, null, 0);
+ // Make sure the timestamp of the mutations are not in the future
Review Comment:
If you do that then whenever we change the code in generateChanges, then we
need to change the code here. Also, it is not straightforward to see how much
time spent in generateChanges and thus it is not easy for a reader to see if we
use the correct timestamp in the past. Further, I am sure if there will be some
side effect if we rewind the time back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
