haridsv commented on code in PR #1964:
URL: https://github.com/apache/phoenix/pull/1964#discussion_r1774783267
##########
phoenix-core-client/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##########
@@ -1634,7 +1636,9 @@ public MutationState createIndex(CreateIndexStatement
statement, byte[][] splits
Map<String,Object> tableProps =
Maps.newHashMapWithExpectedSize(statement.getProps().size());
Map<String,Object> commonFamilyProps =
Maps.newHashMapWithExpectedSize(statement.getProps().size() + 1);
- populatePropertyMaps(statement.getProps(), tableProps,
commonFamilyProps, PTableType.INDEX);
+ populatePropertyMaps(statement.getProps(), tableProps,
commonFamilyProps, PTableType.INDEX,
+ CDCUtil.isCDCIndex(SchemaUtil
+
.getTableNameFromFullName(statement.getIndexTableName().toString())));
Review Comment:
Do we need this special handling considering `createCDC` is explicitly
adding `REPLICATION_SCOPE=0` property? We need only one of these right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
