haridsv commented on code in PR #1964:
URL: https://github.com/apache/phoenix/pull/1964#discussion_r1774997639


##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/CDCQueryIT.java:
##########
@@ -701,8 +698,14 @@ public void testCDCIndexBuildAndVerification() throws 
Exception {
             }
 
             long startTS = System.currentTimeMillis();
-            generateChanges(startTS, tenantids, tableFullName, tableFullName, 
COMMIT_SUCCESS, null);
-            EnvironmentEdgeManager.reset();
+            List<ChangeRow> changes = generateChanges(startTS, tenantids, 
tableFullName,
+                    tableFullName, COMMIT_SUCCESS, null, 0);
+            // Make sure the timestamp of the mutations are not in the future

Review Comment:
   > Further, I am sure if there will be some side effect if we rewind the time 
back.
   
   Tried it in an IT, some future calls get stuck in sleep, I think sleep 
duration is getting miscalculated somewhere.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to