stoty commented on PR #2083: URL: https://github.com/apache/phoenix/pull/2083#issuecomment-2684051219
I disagree with your assumption that hbase.zookeeper.quorum and hbase.zookeeper.client.quorum have different semantics, and should have different values. IIRC the HBase behaviour is that hbase.zookeeper.client.quorum is the primary property, and hbase.zookeeper.quorum is the fallback if the client one is undefined, there is no other semantic difference, and I think we should honor that. Phoenix should still behave consistently is new-style quorums with heterogenous prots are used, it should not set invalid quorum properties in that case. You have a point in that Phoenix should not change the quorum properties in coming either from hbase-site.xml or specified via the URL, but I think that you are trying to fix that in the wrong way. I think that right solution is to leave the hbase-site.xml properties alone, and just naively copy the strings from the URL into both hbase.client.zookeeper.quorum and hbase.zookeeper.quorum (and for old-style URLs also set the port properties), AND somehow store phoenix-specific property that we can use to select the correctl CQSI object. This would only require changing ConnectionInfo so that it sets all the quorum-related properties based on the non-normalized quorum properties/URL components. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
