jpisaac commented on code in PR #2083:
URL: https://github.com/apache/phoenix/pull/2083#discussion_r1971832670


##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ZKConnectionInfo.java:
##########
@@ -83,6 +95,10 @@ public ReadOnlyProps asProps() {
             //This has the highest priority
             connectionProps.put(HConstants.CLIENT_ZOOKEEPER_QUORUM, 
getZkHosts());
         }
+        String zkHostsWithoutPorts = getZkHostsWithoutPorts();
+        if (zkHostsWithoutPorts != null) {
+            connectionProps.put(HConstants.ZOOKEEPER_QUORUM, 
zkHostsWithoutPorts);

Review Comment:
   @virajjasani We should be keeping this property the same as the  
CLIENT_ZOOKEEPER_QUORUM, Right!, 
   Since that's the ZK spec and should have the right format/spec to make the 
connection. The only backward compatibility issue was that it was not set 
earlier causing upstream application to misbehave.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to