virajjasani commented on code in PR #2083:
URL: https://github.com/apache/phoenix/pull/2083#discussion_r1971985012
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ZKConnectionInfo.java:
##########
@@ -83,6 +95,10 @@ public ReadOnlyProps asProps() {
//This has the highest priority
connectionProps.put(HConstants.CLIENT_ZOOKEEPER_QUORUM,
getZkHosts());
}
+ String zkHostsWithoutPorts = getZkHostsWithoutPorts();
+ if (zkHostsWithoutPorts != null) {
+ connectionProps.put(HConstants.ZOOKEEPER_QUORUM,
zkHostsWithoutPorts);
Review Comment:
The backward compatibility issue is that 5.1 client never returned port
number from ConnectionInfo whereas here if we don't do this, 5.2 client will
always have port info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
