kadirozde commented on code in PR #2134:
URL: https://github.com/apache/phoenix/pull/2134#discussion_r2066982061
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/TableTTLIT.java:
##########
@@ -273,10 +273,12 @@ public void
testMinorCompactionShouldNotRetainCellsWhenMaxLookbackIsDisabled()
Thread.sleep(1);
}
flush(TableName.valueOf(tableName));
- // Flushes dump and retain all the cells to HFile.
- // Doing MAX_COLUMN_INDEX + 1 to account for empty cells
- assertEquals(TestUtil.getRawCellCount(conn,
TableName.valueOf(tableName), row),
- rowUpdateCounter * (MAX_COLUMN_INDEX + 1));
+ // At every flush, extra cell versions should be removed.
Review Comment:
We need to rename this test method to
testMinorCompactionAndFlushShouldNotRetainCellsWhenMaxLookbackIsDisabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
