tkhurana commented on code in PR #2134:
URL: https://github.com/apache/phoenix/pull/2134#discussion_r2069025425
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java:
##########
@@ -611,6 +612,29 @@ private boolean areMutationsInSameTable(Table
targetHTable, Region region) {
region.getTableDescriptor().getTableName().getName()) == 0);
}
+ @Override
+ public InternalScanner
preFlush(ObserverContext<RegionCoprocessorEnvironment> c, Store store,
+ InternalScanner scanner,
FlushLifeCycleTracker tracker)
+ throws IOException {
+ if (!isPhoenixTableTTLEnabled(c.getEnvironment().getConfiguration())) {
Review Comment:
We are using the same config to control both flushing and compaction. Will
there be a scenario where we want to disable Phoenix compaction on flushing but
still continue to use Phoenix compaction for major/minor compaction ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
