virajjasani commented on PR #2134:
URL: https://github.com/apache/phoenix/pull/2134#issuecomment-2840187247
Not related to this PR, but as a general improvement, this method should not
be named as `isEmptyColumn()` because it does not perform any empty column
related check, all it checks for is whether the given cell has matching CF and
CQ:
```
public static boolean isEmptyColumn(Cell cell, byte[] emptyCF, byte[]
emptyCQ) {
return CellUtil.matchingFamily(cell, emptyCF, 0, emptyCF.length) &&
CellUtil.matchingQualifier(cell, emptyCQ, 0, emptyCQ.length);
}
```
We should remove the above utility because HBase CellUtil already provides
exactly the same:
```
public static boolean matchingColumn(final Cell left, final byte[] fam,
final byte[] qual) {
return matchingFamily(left, fam) && matchingQualifier(left, qual);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
