tkhurana commented on code in PR #2411:
URL: https://github.com/apache/phoenix/pull/2411#discussion_r3113419216
##########
phoenix-core-server/src/main/java/org/apache/phoenix/mapreduce/PhoenixInputSplit.java:
##########
@@ -39,6 +39,7 @@ public class PhoenixInputSplit extends InputSplit implements
Writable {
private List<Scan> scans;
private KeyRange keyRange;
+ private List<KeyRange> keyRanges;
Review Comment:
keyRange is redundant now. It's just the span from
`keyRanges.get(0).getLowerRange()` to `keyRanges.get(last).getUpperRange()`.
You can keep only keyRanges and derive the overall bounds on demand:
```suggestion
public KeyRange getKeyRange() {
return KeyRange.getKeyRange(
keyRanges.get(0).getLowerRange(),
keyRanges.get(keyRanges.size() - 1).getUpperRange());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
