haridsv commented on PR #2411: URL: https://github.com/apache/phoenix/pull/2411#issuecomment-4312521700
> I saw progress being reported incrementally from 0->100. I think progress is being reported based on how many mapper pending/in-progress/completed. **But you are right that, any mapper which is running will be considered as 0/1 for job completion. There won't be a middle ground.** This (the highlighted) is exactly what I am saying! Also, we wouldn't know in advance how many bytes would be encountered and so there is noe meaningful way to give a percentage based on bytes processed, but this simplification was fine before this change, but not anymore. > I see the formulae at mapper level, Progress = Number of bytes read/Total bytes in Input Split. > Will have to see if we can update bytes read manually in RecordReader. My point is, we know how many splits will be processed by the mapper so we can easily generate a progress based on the number of splits completed. > Do you think we should take this up as follow up ? If you mean, you want to address it in the very next PR, I am fine with it, but I don't think this should be considered as optional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
