tkhurana commented on code in PR #2411:
URL: https://github.com/apache/phoenix/pull/2411#discussion_r3113938212
##########
phoenix-core-server/src/main/java/org/apache/phoenix/mapreduce/PhoenixSyncTableMapper.java:
##########
@@ -88,15 +87,15 @@ public enum SyncCounters {
private Connection globalConnection;
private PTable pTable;
private byte[] physicalTableName;
- private byte[] mapperRegionStart;
- private byte[] mapperRegionEnd;
+ private List<KeyRange> regionKeyRanges;
private PhoenixSyncTableOutputRepository syncTableOutputRepository;
private Timestamp mapperStartTime;
@Override
protected void setup(Context context) throws InterruptedException {
try {
super.setup(context);
+ context.getCounter(SyncCounters.TASK_CREATED).increment(1);
Review Comment:
Isn't this just the number of mappers created ? YARN already maintains that
information. We can simply use the corresponding counter from YARN rather than
maintaining our own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
