apurtell opened a new pull request, #2593: URL: https://github.com/apache/phoenix/pull/2593
Several Phoenix test classes run with `reuseForks=true`, sharing a single in-JVM minicluster across all classes that land on that same fork (via `BaseTest.setUpTestDriver`). This is important for reducing overall test runtime but can be problematic. When the fork's in-JVM minicluster dies this poisons every subsequent class assigned to that same reused fork and causes all manner of malfunction that currently are not handled all that well. We should at least bound the failure blast radius with the following basic test improvements: - Add `<forkedProcessTimeoutInSeconds>1800</forkedProcessTimeoutInSeconds>` to appropriate surefire/failsafe configuration. - Add a global ClassRule `Timeout(20, MINUTES)` to `BaseTest`. Triggers from inside the fork and produces a failure report XML for the wedged test class. - Detect and fail fast on discovery of a dead in-JVM cluster in a shared fork. In `BaseTest.doSetup` after the utility starts, add a health check that verifies that the master is up. This alone may reduce failure case wastage of test runner resources to seconds from hours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
