Copilot commented on code in PR #2593:
URL: https://github.com/apache/phoenix/pull/2593#discussion_r3717012935
##########
pom.xml:
##########
@@ -1647,6 +1647,7 @@
</goals>
<configuration>
<reuseForks>false</reuseForks>
+
<forkedProcessTimeoutInSeconds>1800</forkedProcessTimeoutInSeconds>
<skip>${skipNeedsOwnMiniClusterTests}</skip>
Review Comment:
`forkedProcessTimeoutInSeconds` is only applied to the
`NeedTheirOwnClusterTests` failsafe execution here, but the PR description
calls out reused forks as the main failure mode. The other failsafe executions
in this plugin (`ParallelStatsEnabledTest` / `ParallelStatsDisabledTest`) still
have no forked process timeout, so a wedged reused fork can still hang until
the CI job timeout. Consider applying `forkedProcessTimeoutInSeconds` at the
failsafe plugin `<configuration>` level (or adding it to the reused-fork
executions) so all IT forks are bounded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
