[ 
https://issues.apache.org/jira/browse/ROCKETMQ-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784896#comment-15784896
 ] 

ASF GitHub Bot commented on ROCKETMQ-6:
---------------------------------------

Github user shroman commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/3
  
    @lollipopjin I resolved the conflicts, now you can review.
    How about squashing all commits when you merge after reviewing this issue? 
My concern is -- I merged this to the master, so if I squash, it will be very 
hard for you to review.


> Use logger for exceptions instead of e.printStackTrace()
> --------------------------------------------------------
>
>                 Key: ROCKETMQ-6
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-6
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>             Fix For: 4.0.0-incubating
>
>
> Replace {{e.printStackTrace()}} with {{log.error(...)}} in all core modules, 
> except tests, tools and  examples.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to