[
https://issues.apache.org/jira/browse/ROCKETMQ-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15813627#comment-15813627
]
ASF GitHub Bot commented on ROCKETMQ-6:
---------------------------------------
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/3
Hi, @shroman
About `e.printStackTrace()`, the error message should log to file surely,
but can we keep the `e.printStackTrace()` if the call stack is in broker start
process. IMO, print the error message to `stderr` will be more visualized, the
developers can quick locate the reason why broker start failed.
And I have another question, why this PR prefer to use `+` to concat
string instead of using format string?
> Use logger for exceptions instead of e.printStackTrace()
> --------------------------------------------------------
>
> Key: ROCKETMQ-6
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-6
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
> Fix For: 4.0.0-incubating
>
>
> Replace {{e.printStackTrace()}} with {{log.error(...)}} in all core modules,
> except tests, tools and examples.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
