[ 
https://issues.apache.org/jira/browse/ROCKETMQ-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15813647#comment-15813647
 ] 

ASF GitHub Bot commented on ROCKETMQ-6:
---------------------------------------

Github user shroman commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/3
  
    Hi @zhouxinyu 
    
    I am not sure if I understand your 1st point though, but if you are saying 
about printing to `stdout` or `stderr` so that users can find problems with 
brokers from the command line, for instance, quickly,
    I think this can be configured via logger xml configuration, right?
    
    As for the 2nd point, I used `+` just because I am not sure what is the 
preferred way for the project -- both `+` and `{}` through the project. Shall 
we make a rule for this in http://rocketmq.apache.org/docs/code-guidelines/?


> Use logger for exceptions instead of e.printStackTrace()
> --------------------------------------------------------
>
>                 Key: ROCKETMQ-6
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-6
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>             Fix For: 4.0.0-incubating
>
>
> Replace {{e.printStackTrace()}} with {{log.error(...)}} in all core modules, 
> except tests, tools and  examples.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to