vladiceanu commented on pull request #254: URL: https://github.com/apache/solr-operator/pull/254#issuecomment-817648146
> Thanks so much for the contribution, it is a really great start! > > A few general things still needed: > > * Tests > > * Documentation > > * We need to handle the "no replicas given" better. Right now we default the value if none is given, we should instead provide a default if the statefulset is being created, otherwise don't touch the existing value. I can help with this logic. @HoustonPutman, thank you so much for reviewing the PR and your comments. As we both agree, "no replicas given" doesn't need to be handled any differently. However, I have a few questions regarding the following: - **Tests**: What exactly has to be tested? We are already generating the Labels and assigning them to the objects like services, pods, etc. In the PR we just do another assignment of the labels to the status of the CR object. They can be empty, or have a value of type string. - **Documentation**: I'm of the opinion that this change we make is common to most of the CR and it doesn't change the way how the user defines the object, doesn't require any changes on the existent objects nor on the new ones. What would we need to document, the fact that we support an external component (HPA) to control the number of replicas? We already have `kubectl scale solr` and I think the addition of the `status.selector` field doesn't have to be documented because it doesn't change in any way how the operator operates, and mentioning it in the documentation might bring confusion that we support Solr autoscaling through the operator, which is not true. Please let me know what are your thoughts on this and if I'm missing anything from the context. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
