vladiceanu commented on a change in pull request #254:
URL: https://github.com/apache/solr-operator/pull/254#discussion_r611539547
##########
File path: controllers/solrcloud_controller.go
##########
@@ -575,6 +576,7 @@ func reconcileCloudStatus(r *SolrCloudReconciler, solrCloud
*solr.SolrCloud, new
updateRevision := statefulSetStatus.UpdateRevision
newStatus.Replicas = statefulSetStatus.Replicas
+ newStatus.Selector = "solr-cloud=" + selectorLabels["solr-cloud"]
Review comment:
would it be Ok if we use the labels from `solrCloud.SharedLabels()`?
they are being assigned to the commonService as well and are unique.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
