HoustonPutman commented on pull request #254: URL: https://github.com/apache/solr-operator/pull/254#issuecomment-817944547
As for tests, I just want to make sure that the common service selector labels are always the same as the podSelector status field. That makes sure that in the future, if someone makes a change to the commonService selector, that they have to make the change to the podSelector status field at the same time. Documentation, you are probably right. We will probably need to do some work around metrics in the future to make HPA work better out of the box. At that point we can do a small tutorial/documentation for people who want to use the feature. Maybe we can just add a line stating that the HPA is compatible with the SolrCloud object. I can quickly do both of these 🙂 Thanks for the great work here! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
