HoustonPutman commented on a change in pull request #254:
URL: https://github.com/apache/solr-operator/pull/254#discussion_r611890948
##########
File path: api/v1beta1/solrcloud_types.go
##########
@@ -655,8 +655,8 @@ type SolrCloudStatus struct {
// Replicas is the number of number of desired replicas in the cluster
Replicas int32 `json:"replicas"`
- // Selector field in the CR status is required by the HPA
- PodSelector string `json:"selector"`
+ // PodSelector for SolrCloud pods, required by the HPA
+ PodSelector string `json:"podSelector"`
Review comment:
[From the
docs](https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#scale-subresource),
I think that `Scale.Status.Selector` is a simulated path that corresponds to
the path given in the [labelSelectorPath
variable](https://github.com/apache/solr-operator/pull/254/files#diff-5b42b48b24fb46286ce7159c2e5fce00e033136c59267c565e95d4bcfc6301f8R6455).
I'm ok changing this back if it is indeed required to be that exact path,
but I would want to make sure first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
