vladiceanu commented on a change in pull request #254:
URL: https://github.com/apache/solr-operator/pull/254#discussion_r611895632
##########
File path: api/v1beta1/solrcloud_types.go
##########
@@ -655,8 +655,8 @@ type SolrCloudStatus struct {
// Replicas is the number of number of desired replicas in the cluster
Replicas int32 `json:"replicas"`
- // Selector field in the CR status is required by the HPA
- PodSelector string `json:"selector"`
+ // PodSelector for SolrCloud pods, required by the HPA
+ PodSelector string `json:"podSelector"`
Review comment:
You're right, I just validated, and here is the result:
```
$ k get --raw
"/apis/solr.bloomberg.com/v1beta1/namespaces/my-solr-namespace/solrclouds/my-solr/scale"
...
"status": {
"replicas": 3,
"selector": "solr-cloud=my-solr,technology=solr-cloud"
}
```
The HPA is able to operate too since the `status.selector` for `scale`
subresource exists and it's correct.
Sorry for the confusion. Now I know a bit more about the operator and
kubernetes `scale` subresource 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
