markrmiller commented on pull request #265: URL: https://github.com/apache/solr/pull/265#issuecomment-907046278
The core provider is good. Using a listener is a much better approach for CoreContainer life-cycle. It could use a bit more as well though - shutdown should actually be two parts - advertising the impending shutdown of the node, most easily by removing the zk live node, which actually needs to happen before the webapp or corecontainer starts shutting down - and then actually shutting down, ideally with a configurable grace timeout. That often means playing with Jetty more than the webapp spec to do right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
