vladiceanu commented on a change in pull request #324:
URL: https://github.com/apache/solr-operator/pull/324#discussion_r714931499
##########
File path: controllers/util/solr_util.go
##########
@@ -327,6 +328,13 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud,
solrCloudStatus *solr.SolrCl
}
}
+ // Default preStop hook
+ preStop := &corev1.Handler{
Review comment:
> This looks good to me! But I would like to see a test added 🙂
I was checking around and found that we already have a few tests on
Lifecycle, i.e.
https://github.com/apache/solr-operator/blob/main/controllers/solrcloud_controller_externaldns_test.go#L117,
https://github.com/apache/solr-operator/blob/main/controllers/solrcloud_controller_test.go#L300,
https://github.com/apache/solr-operator/blob/main/controllers/solrcloud_controller_test.go#L396,
and other places.
Are there any other kinds of tests that you think it would make sense to
add? Perhaps just a simple custom input, not based on variables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
