HoustonPutman commented on a change in pull request #324:
URL: https://github.com/apache/solr-operator/pull/324#discussion_r715081864
##########
File path: controllers/util/solr_util.go
##########
@@ -327,6 +328,13 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud,
solrCloudStatus *solr.SolrCl
}
}
+ // Default preStop hook
+ preStop := &corev1.Handler{
Review comment:
The new tests look great, but why did you remove the old tests from the
tests that don't specify a custom lifecycle?
We test those because the ports change between the tests, and we want to
make sure the correct port is always used no matter the solrAddressibility
options specified.
It looks like we are keeping the same default lifecycle, unless I'm missing
something. So those tests wouldn't have to change, I don't think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
