vladiceanu commented on a change in pull request #324:
URL: https://github.com/apache/solr-operator/pull/324#discussion_r715090863
##########
File path: controllers/util/solr_util.go
##########
@@ -327,6 +328,13 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud,
solrCloudStatus *solr.SolrCl
}
}
+ // Default preStop hook
+ preStop := &corev1.Handler{
Review comment:
oh, yes, you're right. In the beginning, I thought it doesn't make sense
if we add podLifecycle ones, but now I see that the point of these tests is to
ensure the correctness of the used port. I have added them back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
