magibney commented on a change in pull request #513:
URL: https://github.com/apache/solr/pull/513#discussion_r783522121
##########
File path: solr/core/src/test/org/apache/solr/response/TestRawTransformer.java
##########
@@ -16,55 +16,151 @@
*/
package org.apache.solr.response;
+import org.apache.commons.io.FileUtils;
import org.apache.solr.SolrTestCaseJ4;
+import org.apache.solr.client.solrj.embedded.JettySolrRunner;
+import org.apache.solr.client.solrj.impl.CloudSolrClient;
+import org.apache.solr.client.solrj.impl.HttpSolrClient;
+import org.apache.solr.client.solrj.impl.NoOpResponseParser;
+import org.apache.solr.client.solrj.request.CollectionAdminRequest;
+import org.apache.solr.client.solrj.request.QueryRequest;
+import org.apache.solr.cloud.MiniSolrCloudCluster;
+import org.apache.solr.cloud.SolrCloudTestCase;
import org.apache.solr.common.SolrInputDocument;
-import org.apache.solr.request.SolrQueryRequest;
+import org.apache.solr.common.params.ModifiableSolrParams;
import org.junit.After;
+import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.Test;
+import java.io.File;
+import java.lang.invoke.MethodHandles;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.Properties;
+
/**
* Tests Raw JSON output for fields when used with and without the unique key
field.
*
* See SOLR-7993
*/
-public class TestRawTransformer extends SolrTestCaseJ4 {
+public class TestRawTransformer extends SolrCloudTestCase {
+
+ private static final String DEBUG_LABEL =
MethodHandles.lookup().lookupClass().getName();
+
+ /** A basic client for operations at the cloud level, default collection
will be set */
+ private static JettySolrRunner JSR;
Review comment:
I take your point. It does try to follow some of the de facto
conventions that @hossman seems to have set out in some tests, which are some
of the most robust I could find (or at least the best among those with which
I'm familiar?) -- e.g.
[TestCloudJSONFacetSKGEquiv](https://github.com/apache/solr/blob/c7abf3f32ca439b73fbe0ed5a3a6d70ecc411cbb/solr/core/src/test/org/apache/solr/search/facet/TestCloudJSONFacetSKGEquiv.java#L104).
They're not properly `final` (so all-caps does violate the broader java
convention) -- but as used in the test class they're "final-_ish_" ... so idk.
I'm fine to change it, though perhaps that change will be obviated by an
altogether different approach to cloud vs. standalone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
