magibney commented on a change in pull request #513:
URL: https://github.com/apache/solr/pull/513#discussion_r783524161
##########
File path: solr/core/src/java/org/apache/solr/response/TextResponseWriter.java
##########
@@ -55,6 +58,10 @@
protected Calendar cal; // reusable calendar instance
+ private static final ReturnFields DUMMY_RETURN_FIELDS = new
SolrReturnFields();
Review comment:
Yeah; `== null` was indeed an obvious first choice; but that doesn't
work because it's being used as shorthand to check whether we're in the
appropriate state to do special handling. And some of the "inappropriate" cases
are signified by `null` explicitly passed, which would have matched on `null`.
I could at least comment it or name the variable more clearly. Good point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
