magibney commented on a change in pull request #513: URL: https://github.com/apache/solr/pull/513#discussion_r783530761
########## File path: solr/core/src/java/org/apache/solr/response/RawShimTextResponseWriter.java ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.response; + +import org.apache.solr.common.SolrDocument; +import org.apache.solr.common.util.NamedList; +import org.apache.solr.search.ReturnFields; + +import java.io.IOException; +import java.util.Iterator; +import java.util.Map; + +public class RawShimTextResponseWriter extends TextResponseWriter { + + private final TextResponseWriter backing; + + RawShimTextResponseWriter(TextResponseWriter backing) { + super(null, false); + this.backing = backing; + } + + // convert non-raw to raw. These are the reason this class exists Review comment: I will add javadoc comments to this class to clarify. This class is needed b/c in the case where control of serialization is delegated to `SchemaField`, the API (appropriately) gives no way to indicate that the serialization should be raw. So this class exists as a shim TextResponseWriter that delegates to another TextResponseWriter, with the slight modification that it causes calls to `writeStr(...)` and `writeArray(...)` to delegate to their "raw" counterparts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
