magibney commented on code in PR #1302: URL: https://github.com/apache/solr/pull/1302#discussion_r1081903901
########## solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java: ########## @@ -48,6 +50,7 @@ import org.xml.sax.InputSource; /** Factory for ManagedIndexSchema */ +@NotThreadSafe Review Comment: `noggit.JSONParser.devNull.buf`? Not seeing this anywhere ... even indirectly, I only see XML parsing here. Not sure where JSON anything is coming from. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org