magibney commented on code in PR #1302: URL: https://github.com/apache/solr/pull/1302#discussion_r1081919327
########## solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java: ########## @@ -48,6 +50,7 @@ import org.xml.sax.InputSource; /** Factory for ManagedIndexSchema */ +@NotThreadSafe Review Comment: In any event based on the entirely no-op impl of `noggit.CharArr.NullCharArr` (of which `JSONParser.devNull` is an instance -- `devNull` again lol), I'm pretty sure that this is perfectly fine. The signatures of the methods to which `JSONParser.devNull` is passed accept CharArr, and I guess lift-bot doesn't recognize that in the case of `devNull` there's actually no chance of modifying the backing `buf` (b/c write methods are all no-ops). So I think this is safe to ignore. @sonatype-lift ignore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
