risdenk commented on code in PR #1302:
URL: https://github.com/apache/solr/pull/1302#discussion_r1088145382


##########
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##########
@@ -290,8 +301,9 @@ public ManagedIndexSchema create(
     return schema;
   }
 
-  private InputStream readSchemaLocally() {
+  private InputStream readSchemaLocally(String[] loadedResourceRef) {

Review Comment:
   Couldn't we return a class or record or something else that you could pull 
the `InputStream` and `loadedResource` out of? This is a private method so no 
need to have the whole array stuff?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to