dsmiley commented on code in PR #1302: URL: https://github.com/apache/solr/pull/1302#discussion_r1082129194
########## solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java: ########## @@ -48,6 +50,7 @@ import org.xml.sax.InputSource; /** Factory for ManagedIndexSchema */ +@NotThreadSafe Review Comment: I recall this violation has come up before from other places that indirectly touch JSONParser. I don't know where it's happening here either but it doesn't matter. I'd say mark JSONParser.DevNull as ThreadSafe and Immutable but it's in SolrJ, thus introducing a dependency to JCIP. I'd rather another PR deal with that matter. BTW you needn't tell Lift "ignore"; it's intended for projects that gate PR acceptance on this GitHub action. We gate on nothing but trust :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
