[
https://issues.apache.org/jira/browse/SOLR-16938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757504#comment-17757504
]
David Smiley commented on SOLR-16938:
-------------------------------------
I'm not arguing against env vars, just against loss of solr.xml configuration.
We should have both. Config files better handle more complex configuration.
There is another JIRA where you are maybe the author about unifying config in a
general way so people can configure Solr in a way that suits them and in a more
consistent way and without having to remember to add a dollar-sign bracket
substitution reference just because you/a-user decide you want to use a sys
prop (or env var).
What's wrong with the generic and relatively Solr standard approach we see
today with TracerConfigurator and a PluginInfo general reading of the XML?
Again, I'm not arguing against enhancing such to read ENV/sys-prop.
> Auto configure tracer without a <tracerConfig> tag in solr.xml
> --------------------------------------------------------------
>
> Key: SOLR-16938
> URL: https://issues.apache.org/jira/browse/SOLR-16938
> Project: Solr
> Issue Type: Sub-task
> Components: tracing
> Reporter: Jan Høydahl
> Priority: Major
>
> Spinoff from SOLR-16536. It should now be possible to get rid of the explicit
> {{<tracerConfig>}} config in solr.xml and the pluggable
> {{TracerConfigurator}} class which is initialized in {{CoreContainer}}.
> Instead, the {{opentelemetry}} plugin can self-register statically to the
> global OTEL instance. This will make it sufficient to enable the
> {{opentelemetry}} module to enable tracing. You can also
> [enable/disable|https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/]
> it with env {{OTEL_SDK_DISABLED}}.
> Alternatively, if we are getting away with global instance (SOLR-16937), then
> SolrCore could discover the plugin using SPI or similar as opposed to
> explicit editing of solr.xml.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
