[
https://issues.apache.org/jira/browse/SOLR-16938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757577#comment-17757577
]
Jan Høydahl commented on SOLR-16938:
------------------------------------
Guess I'm inspired by the elegant standardized container-friendly config of the
OTEL stack. It is even standardized across SDKs of various programming
lanuages. We also had this with Jaeger, you could (had to) configure it with
ENV vars. So since the only remaining function of the solr.xml tag was to
enable / bootstrap the plugin, that lead to this proposal.
Start Solr with SOLR_MODULES=opentelemetry and a few more env vars and tracing
is active. As compared to hand editing solr.xml, making sure to keep it up to
date as you upgrade solr versions, figuring out how to deploy solr.xml it into
a container or other env etc etc.
Are you on board with supporting both? I.e. support the solr.xml tag and
config, but not require it in order to use tracing?
> Auto configure tracer without a <tracerConfig> tag in solr.xml
> --------------------------------------------------------------
>
> Key: SOLR-16938
> URL: https://issues.apache.org/jira/browse/SOLR-16938
> Project: Solr
> Issue Type: Sub-task
> Components: tracing
> Reporter: Jan Høydahl
> Priority: Major
>
> Spinoff from SOLR-16536. It should now be possible to get rid of the explicit
> {{<tracerConfig>}} config in solr.xml and the pluggable
> {{TracerConfigurator}} class which is initialized in {{CoreContainer}}.
> Instead, the {{opentelemetry}} plugin can self-register statically to the
> global OTEL instance. This will make it sufficient to enable the
> {{opentelemetry}} module to enable tracing. You can also
> [enable/disable|https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/]
> it with env {{OTEL_SDK_DISABLED}}.
> Alternatively, if we are getting away with global instance (SOLR-16937), then
> SolrCore could discover the plugin using SPI or similar as opposed to
> explicit editing of solr.xml.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
