[
https://issues.apache.org/jira/browse/SOLR-16938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758296#comment-17758296
]
Alex Deparvu commented on SOLR-16938:
-------------------------------------
Sorry for joining this late, I only just saw this now.
Just a few questions:
1. re. "keeping solr.xml config": this is something that does not exist today,
correct? the 'init' params are ignored in the plugin.
2. re. "turning it on without any solr.xml tags". I'm not sure what type of SPI
mechanism exists already in Solr, but for the sake of simplification lets say I
can do a 'OtelTracerConfigurator class exists' check and I will know if otel is
on the classpath or not.
would adding another environment or system property be sufficient (or piggy
back on checking existence of `OTEL_SERVICE_NAME`)? just as a failsafe to make
sure someone does not accidentally add otel module to classpath and starts
seeing a lot of weird errors.
3. I am working on replacing the rid with a proper trace id based on OTEL
(SOLR-15367) but with a very reduced set of telemetry features (only
propagation basically). this will be the default for case 2 above. if the
activation does not happen, Solr will get trace ids only.
I am happy to start chopping away at this if you agree this is what the
consensus is.
> Auto configure tracer without a <tracerConfig> tag in solr.xml
> --------------------------------------------------------------
>
> Key: SOLR-16938
> URL: https://issues.apache.org/jira/browse/SOLR-16938
> Project: Solr
> Issue Type: Sub-task
> Components: tracing
> Reporter: Jan Høydahl
> Priority: Major
>
> Spinoff from SOLR-16536. It should now be possible to get rid of the explicit
> {{<tracerConfig>}} config in solr.xml and the pluggable
> {{TracerConfigurator}} class which is initialized in {{CoreContainer}}.
> Instead, the {{opentelemetry}} plugin can self-register statically to the
> global OTEL instance. This will make it sufficient to enable the
> {{opentelemetry}} module to enable tracing. You can also
> [enable/disable|https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/]
> it with env {{OTEL_SDK_DISABLED}}.
> Alternatively, if we are getting away with global instance (SOLR-16937), then
> SolrCore could discover the plugin using SPI or similar as opposed to
> explicit editing of solr.xml.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
