dsmiley commented on code in PR #1856:
URL: https://github.com/apache/solr/pull/1856#discussion_r1316042617
##########
solr/core/src/java/org/apache/solr/util/tracing/TraceUtils.java:
##########
@@ -158,9 +158,10 @@ public static Span startHttpRequestSpan(HttpServletRequest
request, Context cont
return spanBuilder.startSpan();
}
- public static Span newInterNodeCommunicationSpan(String name) {
+ public static Span newInterNodeCommunicationSpan(String name, String
collection) {
Tracer tracer = TraceUtils.getGlobalTracer();
- SpanBuilder spanBuilder =
tracer.spanBuilder(name).setSpanKind(SpanKind.SERVER);
+ SpanBuilder spanBuilder =
+
tracer.spanBuilder(name).setSpanKind(SpanKind.PRODUCER).setAttribute(TAG_DB,
collection);
Review Comment:
I wasn't clear before and I should make an updated proposal. "inter node
communication" does not imply producer/consumer or RPC for that matter.
https://javadoc.io/doc/io.opentelemetry/opentelemetry-api/0.9.0/io/opentelemetry/trace/Span.Kind.html#PRODUCER
I think where we use "async" on the receiving end (Solr server recipient),
we should use CONSUMER because the caller (the producer) is not waiting on the
response (is not RPC in nature). They would have to issue REQUESTSTATUS checks
to get the final result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
